Various fixes for go 1.22 #3455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aarzilli
commented
Aug 7, 2023
•
aarzilli
commented
- call injection fixes
- updated golang.org/x/tools/packages to support go1.22
- disabled staticcheck test with go1.22 because it does not currently support it
At various point during the execution of the call injection protocol the process is resumed and the call injection goroutine could migrate to a different thread, we must make sure to update our local variables correctly after every point where the target program is resumed. 'fncall122debug_clean' on 'f469a0a5'.
Go 1.22 broke golang.org/x/tools/packages
Go 1.22 is not yet supported by staticcheck.
aarzilli
force-pushed
the
fncall122debug_clean
branch
from
618c73f
to
4f8cf0a
Compare
aarzilli
changed the title
|
The call injection fixes actually also affect problems with versions prior to go1.22. |
|
cc @hyangah TestFatalThrowBreakpoint of server/dap is currently failing with go1.22 because optimizations make the variable holding the error reason unreadable at entry. What do you think we should do about it? |
|
I commented on the issue -- golang/go#62523 (comment) I think there may need to be a Delve change here if possible, unless we want to roll back or change CL http://go.dev/cl/c/go/+/390420 in some way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.